Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

109 my plot diff #110

Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open

109 my plot diff #110

wants to merge 52 commits into from

Conversation

audreyyeoCH
Copy link
Collaborator

closes #109

@audreyyeoCH
Copy link
Collaborator Author

audreyyeoCH commented Sep 22, 2024

the vintage example file is called myPlotDiff.R shows what was intended of this call which has been refactored to plotBetaDiff and has its own example file.

@audreyyeoCH
Copy link
Collaborator Author

Hi @danielinteractive, there's probably some design questions here on how we want the plot to look, could you review and share what do you think please ? The colours chosen are from a colour blind friendly template

@audreyyeoCH audreyyeoCH marked this pull request as draft September 23, 2024 12:44
@audreyyeoCH
Copy link
Collaborator Author

Hi @danielinteractive, I'm about to make .svg files for expect_doppelganger but wanted to check what you think of these plots. I am referring to the crmPack repo to do this... first time!

@audreyyeoCH audreyyeoCH marked this pull request as ready for review January 6, 2025 15:22
@danielinteractive
Copy link
Collaborator

Hi @danielinteractive, I'm about to make .svg files for expect_doppelganger but wanted to check what you think of these plots. I am referring to the crmPack repo to do this... first time!

Hi @audreyyeoCH , ok cool, can you copy/paste screenshots of the plots here? Then it saves me time to install and run the branch package version

@audreyyeoCH
Copy link
Collaborator Author

audreyyeoCH commented Jan 7, 2025

Awesome, thanks for checking them out, here they are:

parX <- c(1, 52) # prior  parameters of experimental arm
parY <- c(5.5, 20.5) # prior  parameters of control or SOC
plotBetaDiff( # plot1
  parY = parY,
  parX = parX,
  Go_cut = 0.3,
  Stop_cut = 0.1, # below a difference of 10%, is an unsuccessful trial
  shade = TRUE,
  note = TRUE
)

plotbetaEx1

With uniform prior

plotBetaDiff( # plot2
parY = c(1, 1), # prior  parameters for experimental arm
  parX = c(1, 1), # prior parameters for control or SOC arm
  Go_cut = 0.3,
  Stop_cut = 0.1, # below a difference of 10%, is an unsuccessful trial
  shade = TRUE,
  note = TRUE
)

plotbetaEx2

@audreyyeoCH
Copy link
Collaborator Author

ok I see we have to fix the P(S)there....

@danielinteractive
Copy link
Collaborator

ok I see we have to fix the P(S)there....

Thanks they look nice, yes I would also think P(Stop) would be better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

109_myPlotDiff
2 participants